Skip to content

Allow multiple level of deriveFrom peripherals. #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2021
Merged

Allow multiple level of deriveFrom peripherals. #529

merged 2 commits into from
Jun 7, 2021

Conversation

ithinuel
Copy link
Member

@ithinuel ithinuel commented Jun 7, 2021

Adds an alias to the base module to allow for multiple level of deriveFrom.

@ithinuel ithinuel requested a review from a team as a code owner June 7, 2021 06:31
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jun 7, 2021
therealprof
therealprof previously requested changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing CHANGELOG.md entry.

@burrbull
Copy link
Member

burrbull commented Jun 7, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 7, 2021

Build succeeded:

@bors bors bot merged commit 2b590ea into rust-embedded:master Jun 7, 2021
@ithinuel ithinuel deleted the deriveFromderived branch June 7, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

@therealprof therealprof therealprof left review comments

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ithinuel @rust-highfive @burrbull @therealprof @ryankurte