register iterator #512
Merged
register iterator #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @therealprof (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
therealprof
reviewed
May 1, 2021
src/generate/register.rs
Outdated
| @@ -1101,10 +1101,10 @@ fn lookup_in_peripheral<'p>( | |||
| base_register: &'p str, | |||
| base_field: &str, | |||
| base_evs: &str, | |||
| all_registers: &[&'p Register], | |||
| mut all_registers: impl Iterator<Item = &'p Register>, | |||
There was a problem hiding this comment.
Hm, why is this mut now?
There was a problem hiding this comment.
Because iteration is mutable one-off operation.
If it is hard to read, I can bring vector and slice back.
There was a problem hiding this comment.
Hm, don't we have a concrete borrowable type for all Registers to pass in? I would expect that can build something like a RegisterMap and pass a reference to it around allowing called functions to obtain their own iter to it.
There was a problem hiding this comment.
I've restored previous behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.