Conversation
|
r? @Emilgardis (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
burrbull
approved these changes
Apr 17, 2021
Member
|
Have you tested all 4 modes? |
Member
Author
|
I guess ideally we should add a CI test for both -g and -m (and combinations) but it didn't seem too easy to add to the current setup. svd2rust works OK with nothing, |
Member
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently projects like stm32-rs have to strip out all the attributes during build to create a file suitable for use as a module. This PR adds a new
-mswitch instead, which causes amod.rsfile to be created without the inner attributes or thepub mod generic/use generic::*lines which would live in the top-levellib.rs.