Skip to content

don't add underscore to end of "is_keyword" #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

burrbull
Copy link
Member

fixes #497

not tested yet

@burrbull burrbull requested a review from a team as a code owner April 14, 2021 03:51
@rust-highfive
Copy link

r? @Emilgardis

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Apr 14, 2021
@burrbull
Copy link
Member Author

should work correct now
cc @therealprof

@burrbull burrbull force-pushed the keyword-sanitize branch 2 times, most recently from 26966b2 to 2feebb2 Compare April 14, 2021 05:54
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@bors bors bot merged commit 3d2c79f into master Apr 16, 2021
@bors bors bot deleted the keyword-sanitize branch April 16, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If reserved name is altered and becomes non reserved, do not add underscore
4 participants