Mips target

[kiffie]

r? @therealprof

Hi all,

Willing to add some basic support for MIPS cores? This patch enables the Peripheral Singleton. I use svd2rust to create PACs for PIC32MX microcontroller.

Best regards,

Stephan

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[burrbull]

Add test if it is possible and update changelog, please.

[Emilgardis]

if possible, add some svd2rust-regress targets as well, not necessary but appreciated.

[kiffie]

svd2rust-regresstarget added.

CHANGELOG.md updated

Reviewing all the code motivated me to move the core access stuff to a new crate mips_mcu to separate it from the startup routine and the ISR tables. I changed my svd2rust patch accordingly.

[burrbull]

Here also, please:
https://github.com/rust-embedded/svd2rust/blob/master/ci/script.sh

[kiffie]

Here also, please:
https://github.com/rust-embedded/svd2rust/blob/master/ci/script.sh

done.

[burrbull]

Update this line and squash commits:

svd2rust/.github/workflows/ci.yml

Line 17 in 6bfc843

VENDOR: [rustfmt, Atmel, Freescale, Fujitsu, Holtek, Nordic, Nuvoton, NXP, RISC-V, SiliconLabs, Spansion, STMicro, Toshiba]

[burrbull]

Looks good to me

[kiffie]

Looks good to me

Yes, the tests passed. In the meantime, I created PACs that include Peripherals::take().

Would be great if you could merge it.

[burrbull]

I still wait you squash commits.

[kiffie]

I didn't realize that there was still an open point because I was not familiar with "squashing" commits. Now everything should be in one single commit.

[burrbull]

bors r+

[bors]

Build succeeded:

• ci-linux (1.37.0, Nordic, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, Atmel, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, Freescale, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, Fujitsu, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, Holtek, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, Nordic, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, Nuvoton, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, NXP, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, RISC-V, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, rustfmt, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, SiliconLabs, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, Spansion, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, STMicro, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, Toshiba, x86_64-unknown-linux-gnu, linux)
• ci-linux (stable, x86_64-apple-darwin, osx)
• ci-linux (stable, x86_64-pc-windows-msvc, windows)

[kiffie]

Cool. @burrbull, thanks a lot for your help and patience.