Skip to content

Fix type path for cluster fields. Allows nested clusters #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2021
Merged

Fix type path for cluster fields. Allows nested clusters #489

merged 1 commit into from
Feb 4, 2021

Conversation

theli-ua
Copy link
Contributor

@theli-ua theli-ua commented Feb 2, 2021 •
edited
Loading

@theli-ua theli-ua requested a review from a team as a code owner February 2, 2021 07:42
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Emilgardis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Feb 2, 2021
Emilgardis
Emilgardis approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 4, 2021

Build succeeded:

@bors bors bot merged commit cc45313 into rust-embedded:master Feb 4, 2021
@theli-ua theli-ua mentioned this pull request Feb 5, 2021
Merged
bors bot added a commit that referenced this pull request Feb 8, 2021
@bors @theli-ua
Merge #491
6bfc843 
491: Fix type paths for arrays of nested clusters r=burrbull a=theli-ua

This is a followup to #489 , this time for arrays


Co-authored-by: Anton Romanov <theli.ua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees

@Emilgardis Emilgardis

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: cannot find type MODE2_ALARM in this scope
3 participants
@theli-ua @rust-highfive @Emilgardis