Skip to content

add debug trait #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2021
Merged

add debug trait #488

merged 1 commit into from
Jan 30, 2021

Conversation

devsnek
Copy link
Contributor

@devsnek devsnek commented Jan 30, 2021 •
edited
Loading

This allows structs which hold peripherals to #[derive(Debug)]

@devsnek devsnek requested a review from a team as a code owner January 30, 2021 20:42
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @burrbull (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jan 30, 2021
@therealprof
Copy link
Contributor

Looks great and doesn't seem to have a big build time impact, once we have the CHANGELOG entry this is good to go.

therealprof
therealprof approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 30, 2021

Build succeeded:

@bors bors bot merged commit 3bc2008 into rust-embedded:master Jan 30, 2021
@devsnek devsnek deleted the debug-trait branch January 30, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@burrbull burrbull

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devsnek @rust-highfive @therealprof @burrbull