Update the min vcell version to v0.1.2
#484
Conversation
`src/generate/generic.rs:53` contains an `as_ptr()` call on a vcell. This was only added in `vcell` v0.1.1 (since yanked). Thus, the generated crates only build with vcell v0.1.2
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
The `register.rs` file included in the output of svd2rust uses `as_ptr()`, which was only added in vcell v0.1.1 (now yanked). See rust-embedded/svd2rust#484
|
Hm, a specification of "0.1.0" should automatically pick up "0.1.2", so this should not cause a build problem unless there's an outdated |
(you already merged this, but I wanna get this in here) That works, but it should build with all allowed combinations, not just the most obvious ones. This could (but pretty unlikely) also lead to problems if some other dependency pins it's vcell version with "=0.1.0". It is a pretty small problem, because otherwise someone else would have noticed before me. |
The `register.rs` file included in the output of svd2rust uses `as_ptr()`, which was only added in vcell v0.1.1 (now yanked). See rust-embedded/svd2rust#484
The `register.rs` file included in the output of svd2rust uses `as_ptr()`, which was only added in vcell v0.1.1 (now yanked). See rust-embedded/svd2rust#484
src/generate/generic.rs:53contains anas_ptr()call on a vcell.This was only added in
vcellv0.1.1 (since yanked).Thus, the generated crates only build with vcell v0.1.2