Skip to content

Use xtensa-lx #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Use xtensa-lx #470

merged 2 commits into from
Sep 20, 2020

Conversation

MabezDev
Copy link
Member

The xtensa runtime and device crates have been merged into a single device and runtime crate, feature gating the CPU features.

  • s/XtensaLX6/XtensaLX/g
  • s/"xtensalx6"/"xtensa-lx"/g
  • Replaces lx6 with the generic lx crate
  • Updates the CI script accordingly

* s/XtensaLX6/XtensaLX/g
* s/"xtensalx6"/"xtensa-lx"/g
* Replaces lx6 with the generic lx crate
* Updates the CI script accordingly
@MabezDev MabezDev requested a review from a team as a code owner September 19, 2020 19:35
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Sep 19, 2020
MabezDev added a commit to esp-rs/esp8266 that referenced this pull request Sep 19, 2020
MabezDev added a commit to esp-rs/esp32 that referenced this pull request Sep 19, 2020
MabezDev added a commit to esp-rs/esp8266 that referenced this pull request Sep 19, 2020
@burrbull
Copy link
Member

Please, remove empty <registers /> from SVD file

@MabezDev
Copy link
Member Author

@burrbull Done! Will now always grab the latest patched SVD from esp32/master.

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot!

@therealprof
Copy link
Contributor

bors r+

@bors bors bot merged commit 72ec77f into rust-embedded:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants