Skip to content

Remove _mut version of alternate register access function #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

burrbull
Copy link
Member

As we use vcell to access register contents, we don't need mutable references for this.

As we use `vcell` to access register contents, we don't need mutable references for this.
@burrbull burrbull requested a review from a team as a code owner August 29, 2020 17:51
@rust-highfive
Copy link

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Aug 29, 2020
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM.

bors r+

@bors bors bot merged commit 74e8004 into master Aug 29, 2020
@bors bors bot deleted the burrbull-patch-1 branch August 29, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants