Skip to content

Improve documentation on generated registers and fields #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

couchand
Copy link
Contributor

Previously, the descriptions for fields were only listed on the docs for the accessor methods on the R and W structs. This adds the descriptions to the field accessor structs so they appear on the register module page, too.

@couchand couchand requested a review from a team as a code owner August 17, 2020 13:16
@rust-highfive
Copy link

r? @reitermarkus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Aug 17, 2020
@burrbull
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Aug 30, 2020
468: Improve documentation on generated registers and fields r=burrbull a=couchand

Previously, the descriptions for fields were only listed on the docs for the accessor methods on the `R` and `W` structs.  This adds the descriptions to the field accessor structs so they appear on the register module page, too.

Co-authored-by: Andrew Dona-Couch <hi@andrewcou.ch>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2020

Build failed:

  • ci-linux (1.37.0, Nordic, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, Atmel, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, Freescale, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, Fujitsu, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, Holtek, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, Nordic, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, Nuvoton, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, NXP, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, RISC-V, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, SiliconLabs, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, Spansion, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, STMicro, x86_64-unknown-linux-gnu, linux)
  • ci-linux (stable, Toshiba, x86_64-unknown-linux-gnu, linux)

@therealprof
Copy link
Contributor

bors retry

@bors bors bot merged commit 73d42ff into rust-embedded:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants