Skip to content

Support as_ptr on a register for DMA and such #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2020
Merged

Support as_ptr on a register for DMA and such #442

merged 2 commits into from
May 8, 2020

Conversation

petrohi
Copy link
Contributor

@petrohi petrohi commented May 7, 2020

No description provided.

@petrohi petrohi requested a review from a team as a code owner May 7, 2020 04:46
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @burrbull (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels May 7, 2020
@burrbull
Copy link
Member

burrbull commented May 7, 2020

Reasonable. LGTM

burrbull
burrbull previously approved these changes May 7, 2020
View reviewed changes
Emilgardis
Emilgardis requested changes May 7, 2020
View reviewed changes
@burrbull
Copy link
Member

burrbull commented May 7, 2020

bors try

bors bot added a commit that referenced this pull request May 7, 2020
@bors
Try #442:
55ff1a1
@therealprof
Copy link
Contributor

@burrbull No need to "try" anymore. GHA is automatically running CI on every commit, cf. https://github.com/rust-embedded/svd2rust/runs/653370311

@burrbull
Copy link
Member

burrbull commented May 7, 2020

reflex 😄

@bors
Copy link
Contributor

bors bot commented May 7, 2020

try

Build succeeded:

@petrohi petrohi requested a review from Emilgardis May 8, 2020 01:53
@therealprof
Copy link
Contributor

bors r=Emilgardis

@bors
Copy link
Contributor

bors bot commented May 8, 2020

Build succeeded:

@bors bors bot merged commit 7f71941 into rust-embedded:master May 8, 2020
@petrohi petrohi deleted the reg_as_ptr branch May 8, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

@burrbull burrbull burrbull left review comments

Assignees

@burrbull burrbull

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrohi @rust-highfive @burrbull @therealprof @Emilgardis