-
Notifications
You must be signed in to change notification settings - Fork 156
Add commit and date info to generated crates #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @burrbull (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach, however, do we need to mention how to generate a "newer" API?
Linking svd2rust repo would be nice though.
Also, I would like it if we switched over to println!("cargo:rustc-env=REV={}", git_rev)
, but that's another pr.
Co-Authored-By: Emil Gardström <emil.gardstrom@gmail.com>
bors r+ |
Build succeeded: |
I don't need this feature as much now, but I know more than once in the past while adding msp430 feature I've forgotten that my changes haven't been incorporated into a release yet.
This means the docs.rs docs are out of date relative to the PAC. I've added some info to the doc string to mention the commit and date that svd2rust was compiled with, and explicitly how to generate up-to-date svd2rust docs.