Remove unnecessary coercions to 'String' + small fixes to doc comments #438
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @burrbull (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
| @@ -240,15 +240,15 @@ | |||
| //! # `read` / `modify` / `write` API | |||
| //! | |||
| //! Each register in the register block, e.g. the `cr1` field in the `I2C` struct, exposes a | |||
| //! combination of the `read`, `modify` and `write` methods. Which methods exposes each register | |||
| //! combination of the `read`, `modify`, and `write` methods. Which method exposes each register | |||
There was a problem hiding this comment.
Looks good to me except these strange commas before and.
There was a problem hiding this comment.
Those are Oxford commas.
|
bors r+ |
|
Build succeeded: |
Remove unnecessary coercions to 'String' + small fixes to doc comments
Thank you for reviewing this PR 😸