Skip to content

more TokenStream extend #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2020
Merged

more TokenStream extend #420

merged 1 commit into from
Jan 2, 2020

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jan 2, 2020

in addition to #416

r? @therealprof

@burrbull burrbull requested a review from a team as a code owner January 2, 2020 19:48
@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jan 2, 2020
@burrbull
Copy link
Member Author

burrbull commented Jan 2, 2020

bors try

bors bot added a commit that referenced this pull request Jan 2, 2020
@therealprof
Copy link
Contributor

Have you checked the performance? It seems that too much TokenStream extension makes everything slower...

@therealprof
Copy link
Contributor

Okay, this one doesn't negatively affect performance, though it doesn't improve it either. ;)

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jan 2, 2020
420: more TokenStream extend r=therealprof a=burrbull

in addition to #416 

r? @therealprof 

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 2, 2020

try

Build succeeded

And happy new year from bors! 🎉

@bors
Copy link
Contributor

bors bot commented Jan 2, 2020

Build succeeded

And happy new year from bors! 🎉

@bors bors bot merged commit f3e80cf into master Jan 2, 2020
@bors bors bot deleted the tokenstreams branch January 2, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants