Skip to content

Adjust CI to test MSRV and allow nightly to fail #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Conversation

therealprof
Copy link
Contributor

We're now documenting an (arbitrarily chosen) MSRV of 1.37.0 and testing
it in CI while also making nightly tests informational only.

Signed-off-by: Daniel Egger daniel@eggers-club.de

@therealprof therealprof requested a review from a team as a code owner January 1, 2020 12:48
@rust-highfive
Copy link

r? @Disasm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jan 1, 2020
@therealprof
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jan 1, 2020
@bors
Copy link
Contributor

bors bot commented Jan 1, 2020

try

Build failed

We're now documenting an (arbitrarily chosen) MSRV of 1.37.0 and testing
it in CI while also making nightly tests informational only.

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@therealprof
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jan 1, 2020
@burrbull
Copy link
Member

burrbull commented Jan 1, 2020

We can merge #381, are we?

@burrbull
Copy link
Member

burrbull commented Jan 1, 2020

LGTM

@therealprof
Copy link
Contributor Author

@burrbull Yes, that's the plan. ;)

@bors
Copy link
Contributor

bors bot commented Jan 1, 2020

try

Build succeeded

And happy new year from bors! 🎉

@burrbull
Copy link
Member

burrbull commented Jan 1, 2020

bors r+

bors bot added a commit that referenced this pull request Jan 1, 2020
413: Adjust CI to test MSRV and allow nightly to fail r=burrbull a=therealprof

We're now documenting an (arbitrarily chosen) MSRV of 1.37.0 and testing
it in CI while also making nightly tests informational only.

Signed-off-by: Daniel Egger <daniel@eggers-club.de>

Co-authored-by: Daniel Egger <daniel@eggers-club.de>
@bors
Copy link
Contributor

bors bot commented Jan 1, 2020

Build succeeded

And happy new year from bors! 🎉

@bors bors bot merged commit 3871c61 into master Jan 1, 2020
@bors bors bot deleted the implement-MSRV branch January 1, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants