Simplify register generation code #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Disasm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
bors try |
tryBuild failed |
burrbull
reviewed
Jan 1, 2020
| fields, | ||
| parent, | ||
| all_registers, | ||
| peripheral, | ||
| all_peripherals, | ||
| )?; | ||
|
|
||
| let pc_r = &f.pc_r; | ||
| let mut pc_w = &f.pc_r; |
There was a problem hiding this comment.
It's kind of hard to see without any comments in the code. ;) I'll have a look at the build results and try to incorporate it in my tests.
There was a problem hiding this comment.
Reader and writer must use one common Enum_A unless field have two enumeratedValues: one for read-only and other for write-only (Enum_AW).
burrbull
reviewed
Jan 1, 2020
| unsafety = None; | ||
| } | ||
|
|
||
| if Some(evs) != evs_r.as_ref() { | ||
| pc_w = &f.pc_w; |
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Signed-off-by: Daniel Egger <daniel@eggers-club.de>
therealprof
force-pushed
the
simplify-register-generation-code
branch
from
b4972d0 to
004a68f
Compare
|
Thanks for the explanation. I added a comment to that effect. |
|
bors try |
tryBuild succeededAnd happy new year from bors! 🎉 |
burrbull
approved these changes
Jan 1, 2020
|
bors r+ |
Build succeededAnd happy new year from bors! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.