Register definitions with the same <name> but different <alternateGroup> generates duplicate structs.

[john-terrell]

I'm unsure I this is a dupe of #357. The SVD here creates duplicate structs.

error[E0428]: the name CMR is defined multiple times
--> pac/atsam4lc2a/src/tc0.rs:151:1
|
147 | pub type CMR = crate::Regcmr::CMR_SPEC;
| ----------------------------------------- previous definition of the type CMR here
...
151 | pub type CMR = crate::Regcmr::CMR_SPEC;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ CMR redefined here
|
= note: CMR must be defined only once in the type namespace of this module

And the code does indeed contain duplicates:

#[doc = "Channel Control Register Channel"]
pub mod ccr;
#[doc = "CMR register accessor: an alias for Reg<CMR_SPEC>"]
pub type CMR = crate::Regcmr::CMR_SPEC;
#[doc = "Channel Mode Register Channel"]
pub mod cmr;
#[doc = "CMR register accessor: an alias for Reg<CMR_SPEC>"]
pub type CMR = crate::Regcmr::CMR_SPEC;
#[doc = "Channel Mode Register Channel"]
pub mod cmr;
#[doc = "CV register accessor: an alias for Reg<CV_SPEC>"]
pub type CV = crate::Regcv::CV_SPEC;

[burrbull]

Can you try different versions of svd2rust an investigate what version (commit) causes this?

[burrbull]

I see such output when run:

[WARN  svd2rust::generate::peripheral] Found type name conflict with region Some("cmr"), renamed to Some("cmr0")
[WARN  svd2rust::generate::peripheral] Found type name conflict with region Some("cmr"), renamed to Some("cmr1")
[WARN  svd2rust::generate::peripheral] Found type name conflict with region Some("cmr"), renamed to Some("cmr2")

[john-terrell]

I tried master and the head of the v0.18 branch.

[burrbull]

CMR is twice described. Check your SVD more carefully.

[burrbull]

alternateGroup's are not supported yet in svd2rust. I see 2 ways to do this:

1. Add ALTERNATE_GROUP_NAME_ prefix for such registers.
2. Put them in different modules and access them using alternate_group_name::REGNAME

[burrbull]

I tried to implement first variant but looks like it works for all registers with alternateGroup in your file except CMR

[burrbull]

Look #506. It should fix your issue.

[burrbull]

Should be fixed now