Skip to content

Allow Nix 0.23 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2021
Merged

Allow Nix 0.23 #33

merged 2 commits into from
Oct 1, 2021

Conversation

m-ou-se
Copy link
Contributor

@m-ou-se m-ou-se commented Oct 1, 2021

This crate compiles fine with nix 0.23 too. This change allows both nix 0.22 and 0.23 as dependency.

@rust-highfive
Copy link

r? @nastevens

(rust-highfive has picked a reviewer for you, use r? to override)

eldruin
eldruin reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Could you also add an entry to the changelog?

eldruin
eldruin approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Oct 1, 2021

Build succeeded:

@bors bors bot merged commit f257420 into rust-embedded:master Oct 1, 2021
@m-ou-se m-ou-se deleted the nix-0.23 branch October 1, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees

@nastevens nastevens

Labels
S-waiting-on-review T-embedded-linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-ou-se @rust-highfive @eldruin @nastevens