Remove build.rs and skeptic from build-deps #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means the readme file is no longer checked for code errors, however the build tree is vastly simplified
|
Instead of completely removing checking of the README, you can actually perform roughly the same tests with rustdoc. Check it out in the fixedvec project: https://github.com/rust-embedded/fixedvec-rs/blob/master/.travis.yml#L30 |
|
Ahh, that's a neat approach! I moved the example to the rustdocs so it gets tested every time, but can revert that and only test in CI if you'd prefer. |
posborne
approved these changes
Nov 8, 2018
|
LGTM; merging (haven't gotten around to setting up bors on this; I can fixup the osx no-op build when I get around to that as well). |
Closed
bors bot
added a commit
to rust-embedded/linux-embedded-hal
that referenced
this pull request
Dec 20, 2018
14: Bump i2cdev version r=therealprof a=ryankurte rust-i2cdev has a new minor version that removes a pile of dependencies (and speeds up builds measurably), see: rust-embedded/rust-i2cdev#47 This PR bumps i2cdev to the updated version and adds a missing newline to the end of cargo.toml Co-authored-by: Ryan Kurte <ryankurte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means the readme file is no longer checked for code errors, however the build tree is vastly simplified.
Related to #41, but it didn't seem worth adding a feature for it.