This repository was archived by the owner on Jul 30, 2025. It is now read-only.
Exclusive should be a wrapper around a reference to the original reso… #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-schievink
approved these changes
Apr 7, 2020
|
🔒 Permission denied Existing reviewers: click here to make jonas-schievink a reviewer |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
7: Exclusive should be a wrapper around a reference to the original reso… r=therealprof a=korken89 Exclusive should be a wrapper around a reference to the original resource. Else it becomes quite useless in conjunction with real resources. This was noticed when moving RTFM to `mutex_trait`, see here: https://github.com/rtfm-rs/cortex-m-rtfm/blob/8073f648cfc967d9efbb2f936e3f0e10a580a64f/examples/generics.rs#L50 (this currently does not compile as we are not taking a reference to the original resource) Co-authored-by: Emil Fresk <emil.fresk@gmail.com>
Timed out |
|
bors r+ |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclusive should be a wrapper around a reference to the original resource. Else it becomes quite useless in conjunction with real resources.
This was noticed when moving RTFM to
mutex_trait, see here: https://github.com/rtfm-rs/cortex-m-rtfm/blob/8073f648cfc967d9efbb2f936e3f0e10a580a64f/examples/generics.rs#L50(this currently does not compile as we are not taking a reference to the original resource)