Skip to content

Document MSRV 1.32.0 and test it on CI #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Document MSRV 1.32.0 and test it on CI #41

wants to merge 1 commit into from

Conversation

@eldruin
Copy link
Member

@eldruin eldruin commented Apr 21, 2020

@eldruin eldruin requested a review from a team as a code owner April 21, 2020 16:57
@rust-highfive
Copy link

r? @posborne

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Review is incomplete T-embedded-linux labels Apr 21, 2020
@adamgreig adamgreig mentioned this pull request Apr 21, 2020
Closed
32 tasks
posborne
posborne previously approved these changes May 21, 2020
View reviewed changes
@posborne
Copy link
Member

posborne commented May 21, 2020 •
edited
Loading

Thanks @eldruin, sorry for the delay in review.

@posborne
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request May 21, 2020
@bors @eldruin
Merge #41
dd88f56 
41: Document MSRV 1.32.0 and test it on CI r=posborne a=eldruin

See: rust-embedded/wg#445

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 21, 2020

Build failed:

@eldruin
Copy link
Member Author

eldruin commented May 22, 2020

Hmm, it does not compile on 1.32.0 due to gpio_cdev pulling in error-chain, which pulls in backtrace, which has a MSRV of 1.40.0. With 1.40.0 it builds fine but it is quite a jump.
Do you want to pull this or do something about those dependencies?

@adamgreig
Copy link
Member

Ping @rust-embedded/embedded-linux, perhaps we could get this merged even at 1.40.0?

@posborne
Copy link
Member

@eldruin There's a new version of gpio_cdev published that drops error-chain which would be another option, but I have no problem with moving to 1.40.0 for the MSRV here either.

@eldruin eldruin mentioned this pull request Jun 10, 2020
Merged
@eldruin
Copy link
Member Author

eldruin commented Jun 10, 2020

@posborne sounds good. Using gpio-cdev 0.3 we how have a MSRV of 1.36.0.
Closing in favor of #42

@eldruin eldruin closed this Jun 10, 2020
bors bot added a commit that referenced this pull request Jun 10, 2020
@bors @eldruin
Merge #42
25bf2be 
42: Update gpio-cdev and add MSRV r=posborne a=eldruin

Using `gpio-cdev` 0.3 we have a MSRV of 1.36.0 due to `nix`.
This superseeds #41 

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@posborne posborne posborne left review comments

Assignees

@posborne posborne

Labels

S-waiting-on-review Status: Review is incomplete T-embedded-linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eldruin @rust-highfive @posborne @adamgreig