Skip to content

Conversation

@eldruin
Copy link
Member

@eldruin eldruin commented Nov 25, 2019

I updated the changelog with everything that happened since the 0.2.2 release.
I also fixed setting the embedded-hal version to 0.2.3 because that is when the digital::v2 traits were released.
This branch sits on top of #26 and fixes #22 and I think also #19.

@eldruin eldruin requested a review from a team as a code owner November 25, 2019 21:53
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Review is incomplete T-embedded-linux labels Nov 25, 2019
@posborne posborne self-requested a review November 25, 2019 23:00
@ryankurte
Copy link
Contributor

lgtm! I do wonder if maybe we should bump minor versions due to the change in I2C behaviour?

@eldruin
Copy link
Member Author

eldruin commented Nov 29, 2019

@ryankurte That is a good question. Fact is that the behavior was incorrect and also different from the behavior of bare-metal embedded-hal implementations so I think that it would have been wrong to rely on it.

@ryankurte
Copy link
Contributor

agreed it was incorrect, i think given that we have all been using it it's worth the bump tho.
also this release also looks like a jump from digital::v1 to digital::v2 which requires the minor bump anyway imo?

@eldruin
Copy link
Member Author

eldruin commented Dec 1, 2019

Ok. Regarding digital::v1/v2 I tried locally with a driver that used v1 and it compiled just fine but maybe I made a mistake somewhere.
Then let's close this and merge #27.

@eldruin eldruin closed this Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Review is incomplete T-embedded-linux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New crates.io release

3 participants