Skip to content

Conversation

@jamesmunns
Copy link
Member

No description provided.

@jamesmunns jamesmunns requested a review from a team as a code owner April 26, 2020 17:57
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @andre-richter (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Apr 26, 2020
@jamesmunns
Copy link
Member Author

r? @jonas-schievink
bors try

bors bot added a commit that referenced this pull request Apr 26, 2020
@bors
Copy link
Contributor

bors bot commented Apr 26, 2020

try

Build failed:

@jamesmunns
Copy link
Member Author

Less lazy this time :)

bors try

@bors
Copy link
Contributor

bors bot commented Apr 26, 2020

try

Build failed:

@jonas-schievink jonas-schievink removed their assignment Jul 6, 2020
@adamgreig
Copy link
Member

This is fixed by #72

@adamgreig adamgreig closed this Aug 8, 2021
@adamgreig adamgreig deleted the update-asm branch August 8, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants