Remove StaticXBuffer, make XBuffer impls require static. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably want to update the crate's documentation as well. |
Merged
|
ping :) |
andrewgazelka
added a commit
to andrewgazelka/embedded-dma
that referenced
this pull request
Nov 17, 2021
- Fixes rust-embedded#17 - Fixes rust-embedded#10 - This is essentially a copy of rust-embedded#13 but with the documentation change requirements that were never made. Since the PR has been stale since March, I found it fair to make another PR.
andrewgazelka
added a commit
to andrewgazelka/embedded-dma
that referenced
this pull request
Nov 17, 2021
- Fixes rust-embedded#17 - Fixes rust-embedded#10 - This is essentially a copy of rust-embedded#13 but with the documentation change requirements that were never made. Since the PR has been stale since March, I found it fair to make another PR.
bors bot
added a commit
that referenced
this pull request
Jan 21, 2022
19: Remove static {read,write} buffers r=eldruin a=andrewgazelka
- Fixes #17
- Fixes #10
- This is essentially a copy of #13 but with the documentation change requirements that were never made. Since the mentioned PR has been stale since March, I found it fair to make another PR.
I am potentially concerned regarding a use case for non-static buffers in the previous docs in the embedded-dma:
> The reason we don't require `'static` in the traits themselves is because it would block implementations that can deal with stack allocated buffers, like APIs that use closures to prevent memory corruption.
Can someone provide an example of an API that use closures to prevent memory corruption? If closures have a valid use case, #18 might be a better option.
Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
Co-authored-by: Andrew Gazelka <andrew.gazelka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10