fix(tlsf): forward realloc to tlsf#124
Open
Conaclos wants to merge 1 commit intorust-embedded:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I am working in an embedded context that shipped some shims for C
realloc. The shim simply delegates the allocation/reallocation to the global Rust allocator.It passed a dummy layout to
alloc::reallocandalloc::dealloc, assuming that the global allocator ignore them and retrieve the original layout on its own.I am currently using the tlsf allocator ad global allocator.
So I discovered a bug where the current
embedded-allocimplementation doesn't ignore the dummy layout in the case of reallocations because it used the default implementation of the Rust library.This is a bug:
reallocshould be forwarded to the underlying rlsf crate.This PR fixes this bug.