Fix and clean up 11-usart by bumping dependencies #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue got fixed with stm32f3 0.13.1 and writing to TDR is safe again. This prepares updating the dependencies to actually use this release.
MonoTimer is used by 11-usart's aux11 module and the buffer-overrun solution. It got deprecated after stm32f3xx-hal release 0.6.1. This is a copy of https://github.com/stm32-rs/stm32f3xx-hal/blob/c68c36c03e0e33699b3b0c9acc3f8d80f5a25cd4/src/time.rs#L91 minus the time units which can be used from embedded-time.
When running 'mdbook test' on the book the example code checking fails to handle for example macros like '#[entry]' and the local auxiliary crates. Having most code examples included from 'examples/' allows to check them at least with 'cargo build --target thumbv7em-none-eabihf --examples'.
Updating stm32f3xx-hal makes accessing these registers safe as it should be.
|
r? @adamgreig (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
Amazing, thank you for pushing this through all the various crates! I'll add CI testing of the examples in a separate PR. bors merge |
|
👎 Rejected by too few approved reviews |
Closed
It was a pleasure and a very interesting journey. :)
Awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate version of #267 which fixes the panic by bumping dependencies. It also addresses the previously unsafe access to the USARTs transmit and receive data registers (TDR and RDR, stm32-rs/stm32-rs#558) by bumping the BSP to the brand spanking new release 0.7.0 which comes with a fixed PAC and HAL. Thank you very much @adamgreig, @Sh3Rm4n, and @rubberduck203 for your patience and support along this journey!
This PR also bumps non-critical dependencies to their actual releases. For example
heapless, which makes use of const generics nowadays.I did not succeed in getting
mdbook testto actually check the example code. I moved it over to theexamplesdirectory and included it in the Markdown files so that it can be checked withcargo build --target thumbv7em-none-eabihf --examples.