Update 06 hello world to use shared cargo config #309
Conversation
|
r? @jamesmunns (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
| @@ -1,8 +1,11 @@ | |||
| [target.thumbv7em-none-eabihf] | |||
There was a problem hiding this comment.
This file should be removed, right? It will clash with #308
There was a problem hiding this comment.
If I'm not mistaken this git showing the deletion of .cargo/config as a "rename", it's confused :) I think when #308 is merged this may change. In anycase there is no src/06-hello-world/.cargo/config in my version of src/06-hello-world.
There was a problem hiding this comment.
Hmm, GitHub is showing a merge conflict with the src/06-hello-world/.cargo/config file. Could you rebase this to master?
|
Merge conflict. |
- Updated `*.md` files. - Deleted the local .cargo/config and openocd.gdb files.
winksaville
force-pushed
the
Update-06-hello-world-to-use-shared-cargo-config
branch
from
92860a7 to
1fdb1c9
Compare
|
fingers crossed :) |
|
Build succeeded: |
|
Weird, it looks like the "staging" step took 27+ minutes with the last two PRs. Where as before it was taking half that time and even earlier staging runs were in the 6 minute range. Is there something about the common ../.cargo/config.toml that is slowing things down? |
|
I would tip this is just the throttling on Travis. Sometimes it hangs forever in the schedule queue. |
4 participants
This is dependent on #308 but there is a reduction in number of lines for 06-hello-world, usually a positive :)