Skip to content

micro:bit: chapter 04; 05 #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Oct 10, 2020
Merged

micro:bit: chapter 04; 05 #271

merged 25 commits into from
Oct 10, 2020

Conversation

hargoniX
Copy link
Member

A rewrite of chapter 04 and partially chapter 05.

I'm already uploading this now since the cargo-embed GDB stub is blowing up on my machine when trying to debug this chip so I'll probably have to spend some time debugging, however during that time my current work can already be reviewed so feel free to take a look at it!

left a TODO at the f3 picture since I need to replace it later on with
another GIF of the micro:bit doing this
@hargoniX hargoniX added this to the Micro:bit rewrite milestone Sep 19, 2020
@hargoniX hargoniX self-assigned this Sep 19, 2020
@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rewrite. Please double check that you specified the right target!

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Sep 19, 2020
@hargoniX hargoniX requested a review from eldruin September 19, 2020 13:22
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

You might be surprised to hear that while "Arm-based" chips are quite
popular, the company behind the "Arm" trademark ([Arm Holdings][]) doesn't
actually manufacture chips for purchase. Instead, their primary business
model is to just *design* parts of chips. They will then license those designs to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to update this once the nVIDIA buyout goes through.

hargoniX and others added 10 commits September 24, 2020 12:12
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
cargo-embed would previously crash once connecting a GDB to its GDB
stub, this is apparently because some regression between 0.8.0 and 0.9
either
* stopped halting the chip automatically once a probe attached
* changed the general behaviour of how the attaching works so much that
  a halt is now required

Either way this seems to fix it so digging into the depths of probe-rs
does not seem to be necessary.
Only cargo embed 0.9.1 includes my fix to overwrite the soft device that
is on the micro:bit board by default in its initial state -> update from
0.9.0 to 0.9.1.
cargo-embed as of now only supports monitor reset, not monitor reset
halt or anything else like that.

Remove those from the GDB appendix.
Originally the blinky was introduced in a single chapter, instead split
it up into two chapters, one introducing embedded-hal and lighting an
LED up and the other (as of now empty one) for introducing the delay
abstractions and letting an LED blink.
@hargoniX
Copy link
Member Author

I left a few notes asking for resources to link to in chapter 5 in the code, would be nice if someone could come up with some suggestions!

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!
I have not looked for a resource for the LED matrix. Maybe there is something in the micro:bit documentation.

hargoniX and others added 3 commits September 27, 2020 16:31
Commas and the likes were never my strength anyways...

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

hargoniX and others added 2 commits September 27, 2020 21:17
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, sounds good to me!

@hargoniX hargoniX marked this pull request as ready for review October 7, 2020 12:45
@hargoniX hargoniX requested a review from a team as a code owner October 7, 2020 12:45
@hargoniX
Copy link
Member Author

hargoniX commented Oct 7, 2020

The PR now contains everything that is required for ch04 and 05 and should be ready for review.

Once review of the last parts passes the only thing we'd need is a nice resource for LED matrices and could actually merge this \o/

@hargoniX hargoniX changed the title WIP: First steps rewrite micro:bit: chapter 04; 05 Oct 7, 2020
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thank you for your work!

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 10, 2020

Build succeeded:

@bors bors bot merged commit 4d68e13 into rewrite Oct 10, 2020
@bors bors bot deleted the first-steps-rewrite branch October 10, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
microbit-rewrite S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants