Add loom support to std critical section implementation
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datdenkikniet
force-pushed
the
loom
branch
3 times, most recently
from
ef4fc42 to
580ef08
Compare
therealprof
approved these changes
Jul 29, 2025
Contributor
therealprof
left a comment
therealprof
left a comment
There was a problem hiding this comment.
Lovely, thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loomis a tool that can be used to validate concurrent programs exhaustively.This PR adds support for
loomto thestdimplementation ofcritical-section, with theloom-suggested approach of using acfgfor it. It raises the MSRV of this project to 1.73 when--cfg loomis specified, but otherwise does not affect it.An example use-case for finding problems using
loomcan be found here. It uses the same critical section implementation as is provided here. Without it,loomassumes that there are no synchronization/interruption points when a critical section starts or ends. Withloom, it runs all the concurrent permutations, and allowed us to repro (though we should've been usingloompreventatively) a concurrency bug.