Skip to content

v0.5.8 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2018
Merged

v0.5.8 #121

merged 3 commits into from
Oct 27, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Oct 27, 2018

required to make a release

we can publish now or wait for #120

@japaric japaric requested a review from a team as a code owner October 27, 2018 11:09
therealprof
therealprof requested changes Oct 27, 2018
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes need updating for #120.

@japaric
v0.5.8
ed7a8c8 
required to make a release

we can publish now or wait for #120
@japaric
incorporate #120 into the CHANGELOG
1ad665a
@japaric
Copy link
Member Author

japaric commented Oct 27, 2018

added #120 to the changelog

therealprof
therealprof reviewed Oct 27, 2018
View reviewed changes
CHANGELOG.md Outdated
### Changed

- The `NVIC.{clear,set}_pending` methods have been deprecated in favor of
`NVIC::{,un}pend`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{,un} reads like a typo to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed this line to {unpend,pend}

therealprof
therealprof approved these changes Oct 27, 2018
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Oct 27, 2018
@bors @japaric
Merge #121
8fd4547 
121: v0.5.8 r=therealprof a=japaric

required to make a release

we can publish now or wait for #120

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Oct 27, 2018

Build succeeded

@bors bors bot merged commit b6a4eba into master Oct 27, 2018
@bors bors bot deleted the release branch October 27, 2018 13:10
@japaric
Copy link
Member Author

japaric commented Oct 27, 2018

Published: https://crates.io/crates/cortex-m/0.5.8

adamgreig pushed a commit that referenced this pull request Jan 12, 2022
@bors @japaric
Merge #121
403d888 
121: link.x: EXTERN(__INTERRUPTS) must come before PROVIDED r=therealprof a=japaric

or the user defined interrupts will be discarded when using fat LTO as seen
in #120

fixes #120

r? @rust-embedded/cortex-m (anyone)

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@japaric @therealprof