Skip to content

implements strcat and strrchr #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

rafaelbeckel
Copy link
Contributor

No description provided.

@thejpster
Copy link
Member

Thank you for this PR! I left a few notes about the code organisation.

@rafaelbeckel
Copy link
Contributor Author

@thejpster I addressed the comments and kept each function in their separate files.

My editor applied some minor linting rules to the README; I left them there, but I can revert if you'd like.

@thejpster
Copy link
Member

Please do revert the README changes - it hides the actual change. Please could you also ensure your doc comments start with a single line of text and then a couple of newlines. If you look at the cargo doc before and after you'll see that this simplifies the summary for each function.

@thejpster thejpster added this pull request to the merge queue Aug 26, 2024
Merged via the queue into rust-embedded-community:master with commit d13967b Aug 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants