-
Notifications
You must be signed in to change notification settings - Fork 14
Add signals with atomic usize #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The |
If we left it to the end user binary to enable the cs feature on portable atomic we'd need a binary in the tree to do a test build. Or we could add a flag for test build purposes I guess. Or we could just not build for those targets. |
What about adding a critical-section feature? The |
Good idea! Done. Have also serialised the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, could you add an entry to the changelog about this?
Adding this to today's todo pile. |
Better than doing it by target.
ebc0b53
to
d889219
Compare
An alternative signal implementation using AtomicUsize.