float inf nan #64
Merged
float inf nan #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* they are not valid JSON numbers * this behavior matches serde-json
* this is not what serde_json does (it errors instead) * but it makes ser/de somewhat symmetric
eldruin
reviewed
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
f{32,64}::NAN,INFINITEandNEG_INFINITY(i.e. if!v.is_finite()) are all emitted like theirryuserializations. This is wrong and breaks JSON.Instead, emit
null, likeserde_jsondoes.On deserialization, interpret
nullasNANwheref32orf64is expected. This isn't exactly whatserde_jsondoes (it errors out instead), but makes the round-trip closer and somewhat more robust. And many would claim that it is common to interpret a JSONnullasNANwhere a float is expected (from schema/context/protocol).