Remove wrong note about missing string escaping. #100
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldruin
reviewed
Nov 18, 2025
Member
eldruin
left a comment
eldruin
left a comment
There was a problem hiding this comment.
Thank you! could you rebase this?
String escaping during serialization is implemented and tested.
eldruin
force-pushed
the
remove-wrong-note-about-string-escaping
branch
from
38ca690 to
c030763
Compare
eldruin
approved these changes
Nov 18, 2025
Member
eldruin
left a comment
eldruin
left a comment
There was a problem hiding this comment.
Ok I could do it with The GitHub interface. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String escaping during serialization is implemented and tested.
Closes #92
/edit: See #102 for a fix for CI.