Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: on multi-block writes send ACMD23 and wait not busy #93

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix: on multi-block writes send ACMD23 and wait not busy #93

merged 2 commits into from
Sep 15, 2023

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Sep 15, 2023 •
edited
Loading

  • Wait not busy fixes multiblock writes at least for the SD card I was using (SanDisk extreme 32 GB) otherwise I was getting a Timeout
  • Sending ACMD23 can considerably improve writing speeds for some cards which pre-erase the blocks.

jonathanpallant
jonathanpallant approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@jonathanpallant jonathanpallant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jonathanpallant jonathanpallant added this pull request to the merge queue Sep 15, 2023
Merged via the queue into rust-embedded-community:develop with commit 13d0cc1 Sep 15, 2023
4 checks passed
@elpiel
Copy link
Contributor Author

elpiel commented Sep 15, 2023

Thanks for acting quick 😋

@jonathanpallant
Copy link
Collaborator

If you have a moment, you might like to take a look at #95

@elpiel
Copy link
Contributor Author

elpiel commented Sep 18, 2023

Yes, will do! Sadly I do not use the Fat32 implementation any more but I will be happy to take a look at the PR and provide feedback.

@elpiel elpiel deleted the fix/multiblock-writes branch September 18, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpallant jonathanpallant jonathanpallant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elpiel @jonathanpallant