Progress towards fixing akaze orientation #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2023
|
@stephanemagnenat Please feel free to push directly to the upstream branch. You should now have permissions to do so. |
|
@vadixidav pushing to upstream failed: |
|
@stephanemagnenat I just updated the default permissions for members, and I believe that you should be able to now push to the branch. Please add your changes to that branch. If you need to force push that is fine too, just preserve the changes. Also, please test against akaze using the changes I added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains my further changes for correcting Akaze's orientation, without the dump functions (the version with the dump is here).
I kept the corrections in different commits.
I used imageproc for running the Gaussian filters, but I retained the kernel from Akaze because it is properly normalized. I did not remove the now-unused functions
horizontal_filterandvertical_filter. Should I remove them?@vadixidav it is unclear for me whether you expected me to push directly in the branch on this repository, so I did this PR.