Duplicate the rust-toolchain file so the crate can be published #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
parasyte
commented
Jun 16, 2022
parasyte
commented
- This is unfortunate, but the crate must include a copy of the rust-toolchain file since it needs to build ROMs with this version.
- When updating the toolchain file, both copies need to be kept in sync.
- Maybe it is worth writing a build script that will ensure they are identical...
- Sounds challenging! The build script must work when building from the repo and when building in isolation (downloaded from crates.io) It would have to be at least smart enough to figure out which scenario it is building in.
- I'll defer that until updating the duplicate toolchain file becomes a problem.
- This is unfortunate, but the crate must include a copy of the rust-toolchain file since it needs to build ROMs with this version. - When updating the toolchain file, both copies need to be kept in sync. - Maybe it is worth writing a build script that will ensure they are identical... - Sounds challenging! The build script must work when building from the repo and when building in isolation (downloaded from crates.io) It would have to be at least smart enough to figure out which scenario it is building in. - I'll defer that until updating the duplicate toolchain file becomes a problem.
parasyte
added a commit
that referenced
this pull request
Jun 21, 2022
- Followup to #51 - no longer need to duplicate the rust-toolchain file
Merged
parasyte
added a commit
that referenced
this pull request
Jun 21, 2022
* Fixes the issue described in [Duplicate the rust-toolchain file so the crate can be published #51](#51). * Fixes the bizarre linker error that prevented a proper Rust update in [Update rust-toolchain and dependencies #50](#50). * Updates all packages to Edition 2021. * Moves all examples to the `rrt0` repo. Since that code is not intended to be built on a build platform like Linux, macOS, or Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.