Skip to content

Switch anstyle-roff to anstyle-parse #63

Open

Description

@epage

With #4, we can now use our own parser. We might need to reuse some code from anstyle-stream to do so.

Activity

  1. Calder-Ty commented on Mar 11, 2023

    @Calder-Ty
    Contributor

    Hey I saw this, and saw the work you did forking vte. With the transfer of the
    Roff style code were you thinking of a general purpose bytes or str to anstyle or just
    implement one for the roff crate for now?

  2. epage commented on Mar 11, 2023

    @epage
    CollaboratorAuthor

    Yes, I think it could make sense to make the conversion generic since roff will likely need everything that an anstyle parser would need.

    anstyle-stream has a subset of bytes to anstyle used, just enough to get wincon working. That could be generalized. I lean towards that living in anstyle_parse or anstyle_stream. No preference yet on which of those it should be in.

    This also isn't the most critical of things; I just didn't want to lose track of this.

  3. added a commit that references this issue on May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-styleArea: anstyleC-enhancementCategory: Raise on the bar on expectations

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions