Fix broken stuff #624
Merged
Fix broken stuff #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on #625 while trying to investigate the CI fails. |
|
CI fails, created #626 |
apoelstra
added a commit
that referenced
this pull request
Jul 13, 2023
81b154f Remove docsrs cfg_attributes (Tobin C. Harding) Pull request description: We no longer need to manually configure the docsrs build to highlight feature guards since we use the `doc_auto_cfg` feature. Somehow when we added usage of that feature we forgot to remove the other attributes. Found in CI fail of #624 ACKs for top commit: sanket1729: utACK 81b154f. I don't follow this completely, but yay for removing unnecessary code. apoelstra: ACK 81b154f Tree-SHA512: 9decdc3f71d8f592047eee89f7f4aaf3a08b2643148c6bc5ad7de9edf61acab0ee56bf3c6dbc14493a9d089d492e31f1d379539e256b5eb96c8873c3be702256
tcharding
force-pushed
the
07-13-ci
branch
3 times, most recently
from
7f77069
to
cc17276
Compare
Commit `0e0dcb7f CI: Pin dependencies required for MSRV build` is totally wrong, why did it get through CI? In the CI script do: - `serde_json` is not a dependency of `secp256k1`, remove the pinning - Put the pinning _before_ any call to `cargo` - Pin the transient dependency `wasm-bindgen-test`
This reverts commit 77808b7. dtolnay/rust-toolchain does not support using a matrix as far as I can tell. Since the PR brief description contains "WIP" it looks like the original author (me) was testing this using CI, no idea how this patch got merged.
apoelstra
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goodness me, I made a mess.
Commit
0e0dcb7f CI: Pin dependencies required for MSRV buildis totally wrong, why did it get through CI?Fix broken stuff in the CI script by doing:
serde_jsonis not a dependency ofsecp256k1, remove the pinningcargowasm-bindgen-testAnd then
Revert "WIP: Add toolchain matrix to job"Fix: #626