Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LowerHex and Display for Message #398

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Implement LowerHex and Display for Message #398

merged 1 commit into from
Feb 9, 2022

Conversation

tcharding
Copy link
Member

Implement fmt::LowerHex for Message. Implement Display by calling LowerHex.

Resolves: #251

@tcharding
Implement LowerHex and Display for Message
a209836 
Implement `fmt::LowerHex` for `Message`. Implement `Display` by calling
`LowerHex`.

Resolves: rust-bitcoin#251
apoelstra
apoelstra approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a209836

Maybe we should update the impl_pretty_debug macro to also implement LowerHex and Display..

@apoelstra apoelstra merged commit f97e41a into rust-bitcoin:master Feb 9, 2022
@tcharding tcharding deleted the impl-display branch February 11, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impl Display for Message
2 participants
@tcharding @apoelstra