-
Notifications
You must be signed in to change notification settings - Fork 264
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove derives for ffi wrapped types
Currently we are deriving various traits that call down to the traits implemented in secp265k1-sys that in turn call down to implementations on the inner byte array. Since we cannot guarantee the inner byte arrays in secp256k1-sys this results in trait implementations that may not be stable across versions of the library. For `XOnlyPublicKey`, `KeyPair`, and `ecdsa::Signature` manually implement `PartialEq`, `Eq`, `PartialOrd`, `Ord`, and `Hash` by first converting the type into a form that is guaranteed to be stable across library versions e.g., by serializing it to a known format.
- Loading branch information
Showing
2 changed files
with
108 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters