More csv ctlv fixes #120
Merged
More csv ctlv fixes #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
reviewed
Aug 7, 2020
| @@ -870,8 +870,8 @@ impl<'stack> Stack<'stack> { | |||
| } | |||
| } | |||
|
|
|||
| /// Helper function to evaluate a After Node. Takes no argument from stack | |||
| /// `n CHECKSEQUENCEVERIFY 0NOTEQUAL` and `n CHECKSEQUENCEVERIFY` | |||
| /// Helper function to evaluate a Older Node. Takes no argument from stack | |||
There was a problem hiding this comment.
I don't think you mean to change After to Older here; ditto in the other function's comment.
sanket1729
force-pushed
the
more_cltv_csv_fixes
branch
from
47d0ab1 to
bdc9334
Compare
apoelstra
approved these changes
Aug 27, 2020
sanket1729
force-pushed
the
more_cltv_csv_fixes
branch
from
bdc9334 to
b0103a7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still discovering remains of #37.