Heavy nest #101
Heavy nest #101
Conversation
sanket1729
force-pushed
the
heavy_nest
branch
2 times, most recently
from
c3172b4 to
9c388a4
Compare
apoelstra
left a comment
apoelstra
left a comment
There was a problem hiding this comment.
ACK.
As discussed on IRC, this PR is more-or-less a stopgap before we implement a more general solution (eliminating recursion everywhere). It should prevent any Miniscript from existing, except by manual data structure construction, which is deep enough to trigger an overflow. Currently Bitcoin Script limits prevent any more deeply-nested Miniscript from being a valid Script anyway.
However, this won't be true in Taproot, and it will probably not always be true in Elements, and it certainly won't be true for the Simplicity analogue of Miniscript.
| /// Attempt to parse a script into a Miniscript representation | ||
| pub fn parse(script: &script::Script) -> Result<Miniscript<bitcoin::PublicKey>, Error> { | ||
| // Transactions more than 100Kb are non-standard | ||
| if script.len() > 10000 {} |
There was a problem hiding this comment.
Is this missing to return Err?
Is it missing a 0 to be 100k?
There was a problem hiding this comment.
Thanks for the reivew :) . Good catch, will fixup shortly
3 participants
Fixes #41 .
Adds robustness to miniscript creation from policy compiler, bitcoin script, and string.