Tracking PR for release 0.18.0
#313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
10-30-bump-version
branch
from
ee183d6 to
ee80db8
Compare
Member
Author
|
Other possible PRs that look ready/interesting for next release: |
Member
Author
|
I messaged @stevenroose on another platform but for transparency I'd like to know what's the status of this crate? Are you watching this repo @apoelstra? In order to upgrade |
Collaborator
|
Yeah, to upgrade bitcoind I need an upgrade here, I just merged #312 to move things forwards, but we will need steven to publish. |
tcharding
force-pushed
the
10-30-bump-version
branch
2 times, most recently
from
9fe7f51 to
a89d803
Compare
romanz
approved these changes
Nov 6, 2023
Upgrade to the recent bitcoin v0.31.0 release by doing: - Remove dependency on `bitcoin_private`, use hex stuff from `bitcoin::hex` (re-export of `hex-conservative`). - Do type renames. - Add a couple of type annotations when parsing `Address`.
Add changelog entry and bump the version number of the `json` crate.
tcharding
force-pushed
the
10-30-bump-version
branch
from
a89d803 to
f0efe22
Compare
RCasatta
approved these changes
Nov 13, 2023
stevenroose
reviewed
Nov 15, 2023
| assert!(cl.add_multisig_address(addresses.len(), &addresses, None, Some(json::AddressType::Bech32)).is_ok()); | ||
| } | ||
|
|
||
| #[rustfmt::skip] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what we want to consider for merge before cutting the next release but at least we need: