Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

key: Impl From<secp256k1::PublicKey> for bitcoin::PublicKey #1949

Merged
merged 2 commits into from
Jul 21, 2023
Merged

key: Impl From<secp256k1::PublicKey> for bitcoin::PublicKey #1949

merged 2 commits into from
Jul 21, 2023

Conversation

stevenroose
Copy link
Collaborator

No description provided.

apoelstra
apoelstra approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ebcce38

@apoelstra
Copy link
Member

This may be mildly controversial since it could cause confusing behavior for somebody who cares about compressedness. But I think that set is pretty-much nobody today, so it's fine by me.

tcharding
tcharding approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ebcce38

I'm getting super itchy to improve the state of affairs re keys.

@apoelstra apoelstra merged commit f50bb05 into rust-bitcoin:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenroose @apoelstra @tcharding