feat: Add end-to-end bitcoin-rpc-midas integration test
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `bitcoin-rpc-midas` as a dependency in `integration_test/Cargo.toml`. - Introduces a new test (`bitcoin_rpc_midas.rs`) demonstrating a full PSBT lifecycle: - start bitcoind - create wallet - mine blocks - generate address - create and sign PSBT - finalize and broadcast - confirm transaction - All functionality is exercised through the generated `midas` client with no manual RPC calls. Closes rust-bitcoin#4
|
I'm not exactly sure what this PR is attempting to show? IIUC |
|
Hi @tcharding, This PR was an attempt at making the value-add as easy as possible to evaluate for those who understand the ecosystem better than I do. Happy to adapt if you have any bandwidth for guidance 🙂 |
|
I'm still unsure what you want me to do with this PR. I posted on #4, maybe that clears up the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitcoin_rpc_midas.rs) demonstrating a full PSBT lifecycle:midasclient with no manual RPC calls.The test can be run with the following command:
cargo test --test bitcoin_rpc_midas --features 28_0 -- --nocapture
Closes #4