Migrate this repo to forgejo

[tcharding]

Shall we move over to forgejo? The URL would become (non-existent ATM) https://git.rust-bitcoin.org/rust-bitcoin/corepc

We've had three other repos over there for a while now and I personally have had no major issues with it. Wanted to get buy in from @jamillambert and @satsfy before doing the move. Also @tnull and @TheBlueMatt for bitreq.

[satsfy]

From my experience with forgejo, I'm ok with it in principle, no fundamental opposition. I see the discussion.

However, I just created a random PR in my rust-psbt fork to trigger a CI run, which is something I use frequently and liberally to test my diffs on Github, but actions would only run for me in forgejo if an admin enables it for my account. Github gives that for free. This may discourage newcomers and be a pain point.

Additionally, I don't understand why it would be a priority for this repo at the moment. It makes our code much harder to discover. The jobs we run are somewhat heavy, and I don't know how the CI for Forgejo is running, so I can foresee some friction in the CI port or slowness. An upside here is making it harder for people to open AI slop PRs, but I haven't seen many of those recently.

Regardless, I'm ok with the decision and find it valuable to avoid depending on GitHub, but unsure if the costs are worth paying. Not sure if what I said may be worth putting on the discussion thread.

[tcharding]

In my mind all the rust-bitcoin repos are moving so I don't see a reason not to move this one. This issue was more about timing.

On the CI thing I rekon we can get you perms if you want to use it like that but you can also just raise a draft PR and CI will run, right? You are free to use what ever process you like though of course.

[tnull]

Fine by me to do it now/soon. We just moved rust-lightning over and had relatively good experience so far.

One slightly orthogonal but related question might be what the plan is for the binary releases used by electrsd. Right it still points to https://github.com/RCasatta/electrsd/releases/download/electrs_releases (cf.

corepc/electrsd/build.rs

Line 20 in 01ec7a9

const GITHUB_URL: &str =

) which presumably would be changed at some point to point to the corepc repo? And IIUC Forgejo doesn't have the same releases page, so where would the electrs binaries live then?

[jamillambert]

I think everything should move unless there is a reason not to. And I see no reason not to for corepc.

For running CI there is a section in the corepc and rust-bitcoin workflow that will run it on your branch without any PR if you push to a branch named test-ci/** on your own fork, if you have actions enabled. AI thinks this should work on forgejo without needing admin, but I haven't tested it.

on:   # yamllint disable-line rule:truthy
  push:
    branches:
      - master
      - 'test-ci/**'

[TheBlueMatt]

Yea, I'm happy to move this as soon as we want. We had some comments that ended up in the wrong place after we migrated rust-lightning with forgejo 16, so I kinda wanna ask claude to do a pass and see if there's any easily fixable cases before we do more repos. I'll do that this weekend (then we can do test migrations a few times and spot-check before we commit).

[TheBlueMatt]

Okay, claude apears to have fixed the migration bugs (see https://codeberg.org/forgejo/forgejo/issues/13537). Migrate-away!

[TheBlueMatt]

Oops, I see you hit Migrate repository from https://github.com/rust-bitcoin/corepc failed: PR #596 has a file-level review comment (https://github.com/rust-bitcoin/corepc/pull/596#discussion_r3273008282 on bitcoind/sha256/bitcoin-core-31.0-SHA256SUMS by 0xB10C), which cannot be migrated yet, see https://codeberg.org/forgejo/forgejo/issues/13545. I made that a hard error rather than allowing comments to go un-migrated (and they're relatively rarely used!). Clicking the links it looks like you just deleted the comments, which I guess fixes it. I'm happy to also make that not a hard error and just report it (somewhere..)

[tcharding]

Done, thanks. https://git.rust-bitcoin.org/rust-bitcoin/corepc