Add MacroDef for "Macros 2.0"

[jonas-schievink]

No description provided.

[matklad]

Maybe just Macro?

…

On Tuesday, 15 December 2020, Jonas Schievink ***@***.***> wrote: ------------------------------ You can view, comment on, or merge this pull request online at: #16 Commit Summary - Add `MacroDef` for "Macros 2.0" File Changes - *M* rust.ungram <https://github.com/rust-analyzer/ungrammar/pull/16/files#diff-9cb8e748eed1b15897d83d709fd6dfa5e8991d4b76e669b10bf7befe282b234d> (6) Patch Links: - https://github.com/rust-analyzer/ungrammar/pull/16.patch - https://github.com/rust-analyzer/ungrammar/pull/16.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#16>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANB3M5GEHOTRI47RMOF6ALSU6NV5ANCNFSM4U4XBN4Q> .

[jonas-schievink]

I was going to use that for

pub enum Macro {
    MacroRules(ast::MacroRules),
    MacroDef(ast::MacroDef),
}

but yeah, the naming isn't really ideal

[jonas-schievink]

Oh, we already have parsing support for this since rust-lang/rust-analyzer#2628, so it should probably remaing MacroDef here to match the existing work

[matklad]

Ok, lets keep it as Def for now

bors r+

Though, it might still make sense to get rid of Def. We used to have Def suffix on everythign, but removing it a while back made the code read better.

[bors]

Build succeeded:

• Rust