This repository was archived by the owner on Nov 9, 2025. It is now read-only.
Node-ify lifetime #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Dec 14, 2020
Contributor
|
Could check (using |
Member
Author
|
I'm almost certain this will cause problems in RA, would surprise me if not 😄 I can start working on a PR that pulls this in properly first before this gets merged. |
Contributor
|
bord d+ |
Member
Author
|
You typo'd bors. |
Contributor
|
bors d+ |
Contributor
|
✌️ Veykril can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors r+ |
Contributor
|
Build succeeded: |
bors bot
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Dec 16, 2020
6896: Node-ify lifetimes r=jonas-schievink a=Veykril Let's see if this passes the tests 🤞 Depends on rust-analyzer/ungrammar#15 Co-authored-by: Jonas Schievink <jonasschievink@gmail.com> Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com> Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.